Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAX-53 Get sponsored products in productSearch #658

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

thalytafabrine
Copy link
Contributor

@thalytafabrine thalytafabrine commented Mar 4, 2024

What problem is this solving?

https://vtex-dev.atlassian.net/browse/SAX-53

Depends on vtex-apps/store-resources#181

How to test it?

workspace

IMPORTANT: Changing the value to sync won't call sponsored products for all accounts, since they still have to enable the setting fetchSponsoredProductsOnSearch

Screenshots or example usage:

Before (notice the sponsored products appearing later):

Mar-04-2024.14-30-58.mp4
Screenshot 2024-03-04 at 2 23 51 PM

After:

Mar-04-2024.12-17-18.mp4
Screenshot 2024-03-04 at 2 28 07 PM

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@thalytafabrine thalytafabrine requested review from a team as code owners March 4, 2024 12:59
@thalytafabrine thalytafabrine requested review from gvc, eduardoformiga and RodrigoTadeuF and removed request for a team March 4, 2024 12:59
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@thalytafabrine thalytafabrine changed the title Get sponsored products in productSearch SAX-53 Get sponsored products in productSearch Mar 4, 2024
@thalytafabrine thalytafabrine self-assigned this Mar 4, 2024
@thalytafabrine thalytafabrine removed the request for review from RodrigoTadeuF March 4, 2024 14:43
Copy link
Contributor

@hcaula hcaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked the sync and async options!

@thalytafabrine
Copy link
Contributor Author

thalytafabrine commented Mar 6, 2024

I liked the sync and async options!

@hcaula great! I was in doubt about these names hahah not very creative and I was thinking if this could get confused.. but since you liked I feel more comfortable to follow with them :)

@thalytafabrine thalytafabrine force-pushed the feature/search-with-sponsored-products branch from 92f11a5 to a790808 Compare March 7, 2024 12:36
@thalytafabrine thalytafabrine merged commit 14ab8b9 into master Mar 7, 2024
4 of 6 checks passed
@thalytafabrine thalytafabrine deleted the feature/search-with-sponsored-products branch March 7, 2024 12:43
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 7, 2024

Your PR has been merged! App is being published. 🚀
Version 3.129.8 → 3.130.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.search-result@3.130.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants